-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ms5837 driver #18213
add ms5837 driver #18213
Conversation
Because of the hand slip, the following contents have been deleted: |
Modify as recommended by Dagar. |
There are some minor formatting errors causing CI to fail, but this otherwise looks good to go from my perspective. Has this driver actually been tested underwater? |
Yes. |
This drive only gives the absolute pressure reading of the sensor. If it is used in liquid, it is also necessary to calculate the water depth according to the initial conditions (liquid density, air pressure on the liquid surface, etc.). |
Co-authored-by: xn365 <xn_365@163.com>
Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by this pull request
A clear and concise description of the problem this proposed change will solve.
E.g. For this use case I ran into...
Describe your solution
A clear and concise description of what you have implemented.
Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.
Test data / coverage
How was it tested? What cases were covered? Logs uploaded to https://review.px4.io/ and screenshots of the important plot parts.
Additional context
Add any other related context or media.