ina238: Support for ina238 power monitors #18260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDebrunner
force-pushed
the
ina23X
branch
from
2f454e0
to
3d2fc3b
Compare
ThomasDebrunner
force-pushed
the
ina23X
branch
from
3d2fc3b
to
2e6f6c9
Compare
dagar
reviewed
Sep 17, 2021
dagar
added
Drivers 🔧
dagar
reviewed
Sep 17, 2021
ThomasDebrunner
force-pushed
the
ina23X
branch
from
09031e4
to
4c43f32
Compare
ThomasDebrunner
changed the title
ThomasDebrunner
force-pushed
the
ina23X
branch
from
4c43f32
to
47b64f7
Compare
davids5
approved these changes
Sep 20, 2021
|
@davids5 do we need to track which board variants of 5x/6x are carrying the ina238? |
|
@mrpollo because it can be independent of the board., it is more of a question of "What I have plugged in?" Then the user has to set the params for their configuration. |
bkueng
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a driver for the INA237, INA238 and INA239 power modules
Describe problem solved by this pull request
For newer 12S power modules, different chip choices are available. PX4 already contains a driver for the INA228 chip. The INA23X chips differ in that they have less resolution and are cheaper.
Describe your solution
INA23X are very similar to INA228, so this driver is based on the INA228 driver. Constants and the math are different, and the results registers are a different bit-width, so different readout. I implemented this as a standalone driver rather than making the existing INA228 driver too complicated. This way, people can just integrate the driver for the hardware they have.
Describe possible alternatives
Make the INA228 into a general purpose TI-power module driver, with either params to choose the right registers and math or even autodetect.
Test data / coverage
Tested on Skynode
Additional context
Like the INA228 driver, this needs param
SENS_EN_INA23Xdo be set to 1 to be launched.