barometer: Add ICP10100 and ICP1011 #18451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
added
Drivers 🔧
dagar
reviewed
Oct 19, 2021
|
|
||
| // constants for presure calculation | ||
| const float _pcal[3] = { 45000.0, 80000.0, 105000.0 }; | ||
| const float _lut_lower = 3.5 * 0x100000; // 1<<20 |
There was a problem hiding this comment.
Move these constants into the header or even the method where they're used?
You can also make them static constexpr float.
dagar
reviewed
Oct 19, 2021
| } | ||
|
|
||
| // software reset time to be greater than 170us | ||
| usleep(250); |
There was a problem hiding this comment.
This one is small enough, but ideally we shouldn't have any sleeps in these drivers because they'll potentially impact other devices on the same bus. For example see the simple state machine within any of the newer drivers.
PX4-Autopilot/src/drivers/magnetometer/isentek/ist8308/IST8308.cpp
Lines 109 to 116 in b35dd86
dagar
reviewed
Oct 19, 2021
| void _calculate(void); | ||
| bool dataReady(); | ||
| float getTemperatureC(void); | ||
| float getTemperatureF(void); |
There was a problem hiding this comment.
Suggested change
| float getTemperatureF(void); |
mxiaogit
force-pushed
the
cuav_icp10xxx_drive
branch
from
e1d400b
to
945671b
Compare
mxiaogit
changed the title
mxiaogit
force-pushed
the
cuav_icp10xxx_drive
branch
from
945671b
to
2aed49b
Compare
dagar
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.