Follow up to RTL based on remaining flight time #18711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuhrer
reviewed
Nov 24, 2021
src/modules/commander/Commander.cpp
Outdated
| @@ -3662,10 +3662,14 @@ void Commander::battery_status_check() | |||
| // Try to trigger RTL | |||
| if (main_state_transition(_status, commander_state_s::MAIN_STATE_AUTO_RTL, _status_flags, | |||
| _internal_state) == TRANSITION_CHANGED) { | |||
| mavlink_log_emergency(&_mavlink_log_pub, "Flight time low, returning to land"); | |||
| mavlink_log_emergency(&_mavlink_log_pub, "Remaining flight time low, returning to land\t"); | |||
| events::send(events::ID("commander_remaining_flight_time_rtl"), events::Log::Emergency, | |||
There was a problem hiding this comment.
Isn't Emergency a bit too extreme? For comparison, the legacy "RTL due to critical battery" triggers an event with:
events::Log::Critical, events::LogInternal::Info
There was a problem hiding this comment.
You're completely right, thanks! I compared to
which should have the same severity and it's like you describe externallyCritical, internally Info.
I corrected the commit directly.
MaEtUgR
force-pushed
the
rtl-remaining-flight-time-follow-up
branch
from
a40de3b
to
7fc3ba2
Compare
|
@sfuhrer I rebased on master and corrected the severity level. Sorry for the delay. |
sfuhrer
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Follow up to the review here: #18646 (review)
Describe your solution
\tat the end of the deprecatedmavlink_log_emergency()message to make it not show in newer ground stations that support the events interfaceTest data / coverage
I did not specifically test these changes yet.