ManualControlSelector: Enable original PX4 default behavior until QGC catches up #18823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaEtUgR
force-pushed
the
manual-control-default
branch
from
e34cb52
to
080afd9
Compare
|
To add to the anecdata I've seen cases where the default behavior (first come first serve) resulted in confusion and even a crash. |
julianoes
approved these changes
Dec 10, 2021
I've seen a lot of confusion around this but luckily no crash (yet) but that's exactly the motivation. I think if it's clear in the UI that you enable RC/Joystick before configuring/calibrating it we can disable it by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Since #17404 by default only RC is accepted and the original PX4 behavior of only accepting the first source present since boot is not supported anymore. I received somewhat obvious feedback from multiple users that were not aware that this has to be configured now.
Describe your solution
This PR enables the original behavior for default. Additionally I added an option to disable stick input completely which doesn't require specific implementation but should explicitly be possible and documented.
Describe possible alternatives
The goal is to make it mandatory for the user to configure what he's planning to use in the UI. Until this UI exists I recover the default behavior to not piss of numerous people that waste time finding the parameter. We should add the UI and then set the default to disabled such that the workflow is obvious.
Test data / coverage
I added unit tests for both cases and made sure they do exactly what we want.
Additional context
Add any other related context or media.