-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPL06 barometer driver #19229
Add SPL06 barometer driver #19229
Conversation
Signed-off-by: ncer <huangzzk@bupt.edu.cn>
Signed-off-by: ncer <huangzzk@bupt.edu.cn>
Is this the Goertek SPL06-007? https://datasheet.lcsc.com/szlcsc/1907081118_Goertek-SPL06-007_C233787.pdf Could you move it under |
hi, @dagar do you have time to review this patch? Is there any other problems in the patch? |
The change looks good. Do you intend to use this in a custom board or as an external peripheral on existing boards? If external might want to add a parameter like this to autostart. PX4-Autopilot/ROMFS/px4fmu_common/init.d/rc.sensors Lines 146 to 150 in c2c455b
|
I added it behind the condition: SENS_EXT_I2C_PRB, is it OK? |
No, that doesn't scale well and there are potential conflicts that develop over time. It's better to do it explicitly now. All you need to do is add a parameter, and then the little bit of code in rc.sensors. PX4-Autopilot/src/drivers/differential_pressure/ms5525/parameters.c Lines 34 to 41 in c2c455b
PX4-Autopilot/ROMFS/px4fmu_common/init.d/rc.sensors Lines 146 to 150 in c2c455b
|
OK, done. |
removed -q option when starting spl06. |
hi, @dagar , please review the changes. |
@dagar hi |
can this patch be merged? |
Thanks @Ncerzzk |
Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by this pull request
Added the driver of spl06 barometer. as the issue #13547
Describe your solution
it's a simple driver, just like how BMP280 implement.
Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.
Test data / coverage
![spl06](https://user-images.githubusercontent.com/9284611/154826764-bf04b75f-8284-4a69-bab4-9680c793a8a7.jpg)
I tested it on linux(SPI/I2C), while there may be problems on nuttx.
Additional context
if someone could test it on nuttx, it would be very nice. Because of this, I commented the spl06 dir in CMakeFiles, just for someone who really need this driver.