Fix reaction to rejected orbit command #19410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
This is a follow-up to #19362 fixing an already previoulsly existing bug. Thanks to @mrivi for finding it!
When commanding a too large Orbit she got invalid setpoints. I figured out that’s because since the introduction the command handling for flight tasks (which is only used for orbit yet) switches to the most basic position mode flight task upon command parameter rejection.
Describe your solution
mavlink_log
since AMC doesn't support events yet.Test data / coverage
This was tested in simulation to solve the issue and result in an improved user experience because of the error message and the correct command result.