Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mro ctrl zero classic enable all pwm outs #19593

Merged
merged 6 commits into from
May 6, 2022
Merged

Conversation

taileron
Copy link
Contributor

@taileron taileron commented May 5, 2022

enable all available 12 pwm outs, cause io timer 15 is supported now
(I could not get the DMA of io timer 15 activated yet)

Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.

Describe problem solved by this pull request
A clear and concise description of the problem this proposed change will solve.
E.g. For this use case I ran into...

Describe your solution
A clear and concise description of what you have implemented.

Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.

Test data / coverage
How was it tested? What cases were covered? Logs uploaded to https://review.px4.io/ and screenshots of the important plot parts.

Additional context
Add any other related context or media.

enable all available pwm outs, cause io timer 15 is supported now
enable all 12 pwm outs, cause time 15 is supported now
OS file has not to be in the board folder
OS file don´t need to be in the board folder
timer 15 dma seems not to be right
@taileron taileron changed the title Update timer_config.cpp mro ctrl zero classic enable all pwm outs May 5, 2022
dagar
dagar previously approved these changes May 5, 2022
@dagar
Copy link
Member

dagar commented May 5, 2022

Thanks @taileron. I should do a pass to make sure all the Control Zero variants are in sync.

@taileron
Copy link
Contributor Author

taileron commented May 5, 2022

I should do a pass to make sure all the Control Zero variants are in sync.

I think this is the only Cntl Zero board with 12 pwm outputs, all others seem to have only 8 and this has always been unproblematic.

@dagar
Copy link
Member

dagar commented May 5, 2022

I should do a pass to make sure all the Control Zero variants are in sync.

I think this is the only Cntl Zero board with 12 pwm outputs, all others seem to have only 8 and this has always been unproblematic.

That's fine, I just want to 1) understand the handful of differences and 2) have them in sync to the point where the overall diff of the entire board directory shows only the actual differences.

@dagar
Copy link
Member

dagar commented May 5, 2022

Trivial code style fail, can you run make format? https://github.com/PX4/PX4-Autopilot/runs/6310201241?check_suite_focus=true
Screenshot from 2022-05-05 13-59-56

correct format
@dagar dagar merged commit 1f3a78b into PX4:master May 6, 2022
@taileron taileron deleted the patch-6 branch May 6, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants