Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fw_pos_control: purge L1 controller #19629

Merged
merged 7 commits into from
Feb 9, 2023
Merged

fw_pos_control: purge L1 controller #19629

merged 7 commits into from
Feb 9, 2023

Conversation

dagar
Copy link
Member

@dagar dagar commented May 10, 2022 •
edited
Loading

Opening this to identify what's required before we can fully switch the FW position controller over to NPFG and remove L1.

Optional:

  • reset roll integrator for discrete switch in position setpoint, remove "circle mode" handling?
  • do we want a parameter to disable the use of wind estimates entirely? (even if they are available)?
  • how do we determine if wind estimates are "valid"?

@dagar dagar changed the title [DO NOT MERGE] fw_pos_control: purge L1 controller fw_pos_control: purge L1 controller Sep 28, 2022
@dagar dagar marked this pull request as ready for review September 28, 2022 15:52
@KonradRudin KonradRudin force-pushed the pr-fw_l1_purge branch 2 times, most recently from 6027c46 to 02a06df Compare February 7, 2023 09:54
@KonradRudin
Copy link
Contributor

@tstastny can you confirm, that the last commit here is legit?
02a06df

@tstastny
Copy link

tstastny commented Feb 7, 2023

@tstastny can you confirm, that the last commit here is legit?
02a06df

made a few comments on this commit above.

@KonradRudin
Copy link
Contributor

@tstastny and @dagar from your side also good for merge?

tstastny
tstastny approved these changes Feb 9, 2023
View reviewed changes
Copy link

@tstastny tstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe would have some different opinions on naming :) but this is something we can think about later as this is anyway an incremental step. thanks @KonradRudin ! good to purge from my side

@sfuhrer sfuhrer merged commit b9f9f25 into main Feb 9, 2023
@sfuhrer sfuhrer deleted the pr-fw_l1_purge branch February 9, 2023 16:51
@tstastny tstastny mentioned this pull request Apr 6, 2023
Merged
@junwoo091400 junwoo091400 mentioned this pull request Dec 18, 2023
Closed
@sfuhrer sfuhrer mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung-Lim Jaeyoung-Lim Jaeyoung-Lim left review comments

@KonradRudin KonradRudin KonradRudin left review comments

@tstastny tstastny tstastny approved these changes

@sfuhrer sfuhrer sfuhrer approved these changes

@RomanBapst RomanBapst Awaiting requested review from RomanBapst

Assignees

@KonradRudin KonradRudin

Labels
Admin: Cleanup (housekeeping) 🧹 Admin: Enhancement (improvement) 💡 Fixed Wing 🛩️ Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
PX4 FW/VTOL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dagar @KonradRudin @tstastny @Jaeyoung-Lim @sfuhrer