-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUAV V6X board support #19819
CUAV V6X board support #19819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davids5 I believe your proposed change for the RM3100 self test bug does not address the fundamental problem with the current self test implementation. The software timeout needs to be greater than what is programmed into the RM3100 BIST register (0x33). The current implementation sets the BW and BP bits to all 1's (the maximum value). This equates to a timeout value of 480us (4 sleep oscillation cycles per LR timeout period and 4 LR periods for BIST) according to the latest published datasheet. Currently, the driver is waiting 26ms (2*RM3100_INTERVAL) which is significantly longer than required. See pull request #19583 for a proposed fix to address the RM3100 self test failures. I’d be interested to know if my proposed changes address the RM3100 self test failures you are experiencing on your flight controller.
@bmeagher - Thank you! This was not my work, just a continuation of a PR I could not write to. @mxiaogit Let's drop 8ea548d and when #19583 comes it will be fixed |
@davids5 Yes, we can delete it. |
62057c9
to
beb730f
Compare
@mxiaogit - I have dropped that commit and rebased on current master. |
434311a
to
37ce0ac
Compare
37ce0ac
to
f159293
Compare
@davids5 Pixhawk V6X kit will include CAN PMU Lite, can you enable Dronecan battery monitor by default? |
bcf3c43
to
44e3403
Compare
You want to backport this for v1.13.1? |
@dagar - was in the middle of testing and had 2 meetings. I Give me a bit.... |
Well good news it works |
@dagar I do not have time to do the back port do you? |
@dagar @julianoes can you help me get this PR into 1.13 please? |
The v1.13.2 has been released but I have no objections to a v1.13.3 once more backports like this one are in. |
@julianoes we need to make sure things like this don't slip from releases, there doesn't seem to be any process for that currently |
I don't have the overview of all these things and what needs to be backported, sorry. |
@cuhome we are working on a point release for your hardware |
I'm verifying things here. |
|
Continuing #19750 here.
Rebased on current master.