Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUAV V6X board support #19819

Merged
merged 4 commits into from
Sep 22, 2022
Merged

CUAV V6X board support #19819

merged 4 commits into from
Sep 22, 2022

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Jun 20, 2022

Continuing #19750 here.

Rebased on current master.

@davids5 davids5 mentioned this pull request Jun 20, 2022
Copy link
Contributor

@bmeagher bmeagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davids5 I believe your proposed change for the RM3100 self test bug does not address the fundamental problem with the current self test implementation. The software timeout needs to be greater than what is programmed into the RM3100 BIST register (0x33). The current implementation sets the BW and BP bits to all 1's (the maximum value). This equates to a timeout value of 480us (4 sleep oscillation cycles per LR timeout period and 4 LR periods for BIST) according to the latest published datasheet. Currently, the driver is waiting 26ms (2*RM3100_INTERVAL) which is significantly longer than required. See pull request #19583 for a proposed fix to address the RM3100 self test failures. I’d be interested to know if my proposed changes address the RM3100 self test failures you are experiencing on your flight controller.

@davids5
Copy link
Member Author

davids5 commented Jun 23, 2022

@davids5 I believe your proposed change for the RM3100 self test bug does not address the fundamental problem with the current self test implementation. The software timeout needs to be greater than what is programmed into the RM3100 BIST register (0x33). The current implementation sets the BW and BP bits to all 1's (the maximum value). This equates to a timeout value of 480us (4 sleep oscillation cycles per LR timeout period and 4 LR periods for BIST) according to the latest published datasheet. Currently, the driver is waiting 26ms (2*RM3100_INTERVAL) which is significantly longer than required. See pull request #19583 for a proposed fix to address the RM3100 self test failures. I’d be interested to know if my proposed changes address the RM3100 self test failures you are experiencing on your flight controller.

@bmeagher - Thank you! This was not my work, just a continuation of a PR I could not write to.

@mxiaogit Let's drop 8ea548d and when #19583 comes it will be fixed

@mxiaogit
Copy link
Contributor

@davids5 I believe your proposed change for the RM3100 self test bug does not address the fundamental problem with the current self test implementation. The software timeout needs to be greater than what is programmed into the RM3100 BIST register (0x33). The current implementation sets the BW and BP bits to all 1's (the maximum value). This equates to a timeout value of 480us (4 sleep oscillation cycles per LR timeout period and 4 LR periods for BIST) according to the latest published datasheet. Currently, the driver is waiting 26ms (2*RM3100_INTERVAL) which is significantly longer than required. See pull request #19583 for a proposed fix to address the RM3100 self test failures. I’d be interested to know if my proposed changes address the RM3100 self test failures you are experiencing on your flight controller.

@bmeagher - Thank you! This was not my work, just a continuation of a PR I could not write to.

@mxiaogit Let's drop 8ea548d and when #19583 comes it will be fixed

@davids5 Yes, we can delete it.

@davids5 davids5 force-pushed the cuav_v6x_dev_cfg branch 2 times, most recently from 62057c9 to beb730f Compare June 24, 2022 10:38
@davids5
Copy link
Member Author

davids5 commented Jun 24, 2022

@mxiaogit - I have dropped that commit and rebased on current master.

@cuhome
Copy link

cuhome commented Sep 14, 2022

@davids5 Pixhawk V6X kit will include CAN PMU Lite, can you enable Dronecan battery monitor by default?

@davids5
Copy link
Member Author

davids5 commented Sep 14, 2022

@davids5 Pixhawk V6X kit will include CAN PMU Lite, can you enable Dronecan battery monitor by default?

@cuhome Please do a PR against this PR and test it.

@dagar dagar merged commit ed16354 into main Sep 22, 2022
@dagar dagar deleted the cuav_v6x_dev_cfg branch September 22, 2022 15:36
@dagar
Copy link
Member

dagar commented Sep 22, 2022

You want to backport this for v1.13.1?

@davids5
Copy link
Member Author

davids5 commented Sep 22, 2022

@dagar - was in the middle of testing and had 2 meetings. I Give me a bit....

@davids5
Copy link
Member Author

davids5 commented Sep 22, 2022

Well good news it works

@davids5
Copy link
Member Author

davids5 commented Sep 22, 2022

@dagar I do not have time to do the back port do you?

@cuhome
Copy link

cuhome commented Nov 9, 2022

@dagar @davids5 This pr was not merged into the newly released 1.13.1stable, but was merged in 1.13.0master, can you please help me?
image

@mrpollo
Copy link
Contributor

mrpollo commented Nov 24, 2022

@dagar @julianoes can you help me get this PR into 1.13 please?

@julianoes
Copy link
Contributor

The v1.13.2 has been released but I have no objections to a v1.13.3 once more backports like this one are in.

@mrpollo
Copy link
Contributor

mrpollo commented Nov 25, 2022

@julianoes we need to make sure things like this don't slip from releases, there doesn't seem to be any process for that currently

@julianoes
Copy link
Contributor

I don't have the overview of all these things and what needs to be backported, sorry.

@cuhome
Copy link

cuhome commented Dec 5, 2022

@davids5 @dagar How should we deal with it?

@mrpollo
Copy link
Contributor

mrpollo commented Dec 5, 2022

@cuhome we are working on a point release for your hardware

@dagar
Copy link
Member

dagar commented Dec 6, 2022

I'm verifying things here.

@cuhome
Copy link

cuhome commented Dec 6, 2022

image
@dagar Thanks, when there is no gps positioning, the wrong altitude (>1000) (local_position_ned) appears.

@cuhome
Copy link

cuhome commented Dec 6, 2022

image

@mrpollo
Copy link
Contributor

mrpollo commented Jun 26, 2023

@cuhome there's a PR for this #21765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants