Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlightTaskOrbit: parameterize hardcoded maximum radius #20012

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Aug 4, 2022

Describe problem solved by this pull request

For safety/dummy proofing reasons the radius of a multicopter orbit is limited. There were use cases recently that required more than 100m orbit radius limit and that's why I increased the hardcoded limit in #19362 The ground station does not know what the limit is but allows the user to plan an arbitrary radius which then gets rejected by the autopilot.

Describe your solution

For these reasons, I made the maximum radius configurable.

Describe possible alternatives

Alternatively we could remove the maximum radius limit altogether.
- That would allow an infinite unreasonable radius
+ For dummy proofing 1 km radius is already quite large
+ Slightly less complexity and code

Test data / coverage

This was simulation tested separately and together with client ground station code to limit the radius correctly.

@MaEtUgR MaEtUgR self-assigned this Aug 4, 2022
@ThomasDebrunner ThomasDebrunner merged commit 87cbda1 into main Aug 5, 2022
@ThomasDebrunner ThomasDebrunner deleted the orbit-maximum-radius-parameter-upstream branch August 5, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants