Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.13] Fix RTK #20310

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[v1.13] Fix RTK #20310

merged 1 commit into from
Sep 28, 2022

Conversation

julianoes
Copy link
Contributor

Before this fix, this function would stall and somehow never return.

This makes RTK data sent from QGC work on top of v1.13 for me.

Before this fix, this function would stall and somehow never return.
@dagar
Copy link
Member

dagar commented Sep 27, 2022

Fix main first then cherry-pick back? I'm trying to only bring in simple clean backported fixes and otherwise not diverge.

@dagar dagar added the bug label Sep 27, 2022
@dagar
Copy link
Member

dagar commented Sep 27, 2022

FYI @AlexKlimaj

@AlexKlimaj
Copy link
Member

I already fixed this in main.
efcf4c9

@julianoes
Copy link
Contributor Author

@dagar sounds like we can merge it here then.

@dagar
Copy link
Member

dagar commented Sep 27, 2022

Change this branch to cherry-pick efcf4c9?

@julianoes
Copy link
Contributor Author

Which changes this from a bugfix to a refactoring but ok if that's what you want. Also, it means I need to re-test.

@dagar dagar merged commit 2e7df77 into release/1.13 Sep 28, 2022
@dagar dagar deleted the pr-v1.13-fix-rtk branch September 28, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants