Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.13] VTOL takeoff problem hotfix #20568

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Nov 8, 2022

Describe problem solved by this pull request

@OfficerJannis reported that the problem I fixed in #20171 also happened to him on the release 1.13. Also I got basically the same report a second time on Discord from SZ#6337 sadly in private (will not accept that in the future anymore).

So I'm following @julianoes 's valid request here #20171 (comment) and backport the fix to 1.13.

FYI @OfficerJannis

Describe your solution

See #20171

Test data / coverage

This was tested by many people by now on main and reportedly also backported to older versions to fix the original issue.

to avoid float rounding errors leading to tiny acceptance radii
getting considered
…r takeoff items

otherwise a previously adjusted or uninitialized radius from the last flight
can cause problems during the new takeoff
@OfficerJannis
Copy link

@MaEtUgR Thanks for doing the Backport!

SZ is one of my colleges. We want to share our findings here with the Community, that's why you got the information twice.

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Nov 8, 2022

@OfficerJannis Nice, thanks a lot for the clarification and sharing your findings! That's helpful 👍🏻

@julianoes julianoes merged commit 228def6 into release/1.13 Nov 11, 2022
@julianoes julianoes deleted the vtol-takeoff-hotfix-113 branch November 11, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants