Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed-wing attitude control: add option to disable manual yaw #20647

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Nov 21, 2022

Solved Problem

  • yaw stick still maps directly to actuator_controls[YAW] (seems to have been an oversight in 8372a78)
  • not possible to disable manual yawing if not desired

Solution

  • remove direct stick-->controls, only change body_rates_setpoint(2) which is then fed into the controller. Note: body_rates_setpoint(2) is previously calculated by the attitude controller for turn coordination.
  • introduce FW_YR_MAX_ADD param and use instead of FW_Y_RMAX to set the effect of the stick to the rate setpoint. If no effect is desired, it can be set to 0.

Alternatives

We could also completely disable it in any attitude controlled mode?

Test coverage

SITL tested.

…ange yaw rate sp

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@dagar
Copy link
Member

dagar commented Nov 21, 2022

We could also completely disable it in any attitude controlled mode?

Do we know anyone that actually wants it?

Otherwise if keeping it, for manual attitude mode (aka stabilized) we have parameters FW_MAN_R_MAX and FW_MAN_P_MAX, so perhaps something like FW_MAN_YR... would be appropriate here.

@tstastny tstastny changed the title Pr fw att c add option disable manaul yaw main fixed-wing attitude control: add option to disable manual yaw Nov 21, 2022
…n attitude controlled mode

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@sfuhrer sfuhrer force-pushed the pr-fw-att-c-add-option-disable-manaul-yaw-main branch from e522381 to e89be1c Compare November 21, 2022 16:55
@sfuhrer
Copy link
Contributor Author

sfuhrer commented Nov 21, 2022

Do we know anyone that actually wants it?

E.g. for FW landings where you want to align with the runway at the end of the flight. Or on gliders to increase the amount of drag through slipping to land at a steeper angle.

Otherwise if keeping it, for manual attitude mode (aka stabilized) we have parameters FW_MAN_R_MAX and FW_MAN_P_MAX, so perhaps something like FW_MAN_YR... would be appropriate here.

Alright, pushed it as FW_MAN_YR_MAX now.

@dagar dagar merged commit c24f956 into main Nov 22, 2022
@dagar dagar deleted the pr-fw-att-c-add-option-disable-manaul-yaw-main branch November 22, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants