-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logger: restart on file write error #21389
Conversation
This can also happen if the maximum file size is reached.
d221224
to
e95fdbe
Compare
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/how-does-people-deal-with-large-ulog-file/32918/10 |
Hi @bkueng ! I started testing this PR yesterday, and I've let my PX4 ran all night and this morning when I checked the log, I didn't have any. Which was the behaviour before testing with this PR. I assume you've tested it, but I was wondering if you've done long endurance test like I did? |
Yes I tested the error case, but not specifically an endurance test. Do you happen to have the console output (or |
You mean console out or I'll try to have something by the end of the day. |
@bkueng sadly, after 5 hours, the logger stopped logging, and I didn't see anything in the |
I spoke too fast, I don't think there's a way for the |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-community-q-a-november-08-2023/35087/2 |
This can also happen if the maximum file size is reached.