Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sitl_multiple_run.sh #21538

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Update sitl_multiple_run.sh #21538

merged 1 commit into from
Jun 2, 2023

Conversation

gamberoillecito
Copy link
Contributor

Edited line to account for the fact that the file has been moved one level deeper in the folder tree (the same edit should be made in the documentation https://docs.px4.io/main/en/simulation/multi_vehicle_jmavsim.html)

Solved Problem

When following the documentation for multi vehicle simulation using jmavsim I found that the file sitl_multiple_run.sh was moved one level deeper in the folder tree. This change was not updated in the documentation here, and the script (which uses a relative path), was not updated either.

Fixes #{Github issue ID}

Solution

  • Add ../ for enabling the script to find the required file in the correct location
  • Refactor ...

Changelog Entry

For release notes:

Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarfiy page https://docs.px4.io/main/en/simulation/multi_vehicle_jmavsim.html

Alternatives

We could also ...

Test coverage

Context

Related links, screenshot before/after, video

Edited line to account for the fact that the file has been moved one level deeper in the folder tree (the same edit should be made in the documentation https://docs.px4.io/main/en/simulation/multi_vehicle_jmavsim.html)
@junwoo091400
Copy link
Contributor

Thanks for this bugfix! When CI passes we can merge 👍

@Jaeyoung-Lim Jaeyoung-Lim merged commit 99f6d41 into PX4:main Jun 2, 2023
antbre pushed a commit to BioMorphic-Intelligence-Lab/PX4-Autopilot that referenced this pull request Sep 14, 2023
Edited line to account for the fact that the file has been moved one level deeper in the folder tree (the same edit should be made in the documentation https://docs.px4.io/main/en/simulation/multi_vehicle_jmavsim.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants