-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new differential pressure sensor ASP5033 #21568
Conversation
Thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! In order for this to be merged it needs some fixing as commented inline.
src/drivers/differential_pressure/asp5033driver/ASP5033Driver.cpp
Outdated
Show resolved
Hide resolved
src/drivers/differential_pressure/asp5033driver/ASP5033Driver.cpp
Outdated
Show resolved
Hide resolved
src/drivers/differential_pressure/asp5033driver/ASP5033Driver.hpp
Outdated
Show resolved
Hide resolved
src/drivers/differential_pressure/asp5033driver/ASP5033Driver.hpp
Outdated
Show resolved
Hide resolved
src/drivers/differential_pressure/asp5033driver/ASP5033Driver.cpp
Outdated
Show resolved
Hide resolved
src/drivers/differential_pressure/asp5033driver/ASP5033Driver.cpp
Outdated
Show resolved
Hide resolved
src/drivers/differential_pressure/asp5033driver/asp5033driver_main.cpp
Outdated
Show resolved
Hide resolved
In the tests with my Pixhawk 6c after 50-60 min work I got this message : "Baro sensor #0 failure: High Error count . Land immediately and check the system". The ASP5033 still work normally after that. Also by Jenkins tests two hardware checks(cuav_x7pro_test and cubepilot_cubeorange_test) fail with error: "ERROR [gps] timeout, forcing stop". Any idea how to solve this problem and finish the request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! I think this is good to be merged soon. Can you make sure style is fixed? make format
, and check my inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes that shouldn't be there, otherwise this is good to go, thanks for iterating.
@dagar any objections to get this in? |
…t the driver with parameter value, removed DDEBUG_BUILD from COMPILE_FLAGS
…ade variables private
6ade3ed
to
43ed4ad
Compare
I've rebased and force pushed this PR. Let's check CI again now. |
CI looks unrelated. Let's get this in. |
Thank you very much, Julian! |
Thank you for your contribution. Could you like to post a new PR to correct the K value to 7? Its correct K value should be 7. If you need sensor testing, you can contact me jasonsiu@qio-tek.com to provide one. I hope this fix PR will be submitted by the author. Thank you. |
Hello @QioTek , I am not sure, if it was from my sensor. I have only once. I did many tests, and with k=8, the output value was much more stable. |
* added a new driver ASP5033 for measuring the differential pressure and airspeed --------- Co-authored-by: nano <nanobotzhe@abv.bg> Co-authored-by: Denislav Petrov <you@example.com>
Follow-up where I changed it to 7: #22048 |
* added a new driver ASP5033 for measuring the differential pressure and airspeed --------- Co-authored-by: nano <nanobotzhe@abv.bg> Co-authored-by: Denislav Petrov <you@example.com>
Solved Problem
Just added a new driver for differential pressure sensor QioTeck ASP5033
https://www.qio-tek.com/index.php/product/qiotek-asp5033-dronecan-airspeed-and-compass-module/
Solution
Context
simple test video with blowing:
https://mega.nz/file/BnI00RrB#4qJGrwMDJpCevAnu8O7x4A8T5kPWacTT3g5sZol5G7E