Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mavlink_messages] Missmatch between header macros and class used #21603

Merged
merged 2 commits into from
May 24, 2023

Conversation

loicdubois
Copy link
Contributor

Solved Problem

Trying to get the SYSTEM_TIME mavlink stream to work

WARN  [mavlink] stream SYSTEM_TIME not found
ERROR [mavlink] configure_streams_to_default() failed

Fixes #{Github issue ID}

Solution

Simply add the stream corresponding to the right header preprocessor directives

Changelog Entry

Bugfix: SYSTEM_TIME stream not found

Alternatives

Test coverage

  • add stream to desired mode
  • SITL starts without complaining

Context

@junwoo091400
Copy link
Contributor

What is the use case for this? Could you give some context?

@junwoo091400
Copy link
Contributor

Sorry, accidentally closed it!

@dagar
Copy link
Member

dagar commented May 17, 2023

Good catch @loicdubois, perhaps we should just generate this instead.

Copy link
Member

@dagar dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing SYS_STATUS is correct, but SYSTEM_TIME doesn't need to be added.

@loicdubois loicdubois requested a review from dagar May 22, 2023 14:04
@loicdubois
Copy link
Contributor Author

loicdubois commented May 22, 2023

What is the use case for this? Could you give some context?

I actually don't use it, just got a warning by playing around with streams to add and remove. I actually had it commented out at line 379 and was checking which streams were added from the preprocessor directives, not the actual stream list append.

@dagar dagar merged commit 1b9d90e into PX4:main May 24, 2023
@loicdubois loicdubois deleted the fix/mavlink-message-mixed-up branch July 25, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants