-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lights: Add LP5562 RGBLED driver #21649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372/1 |
7101a46
to
1e86cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1e86cf6
to
563179b
Compare
1f3b90c
to
67af398
Compare
This adds support for the TI LP5562 RGB LED driver. Things to note: - The driver is initialized in simple PWM mode using its internal clock, for R,G,B, but not for W(hite). - The chip doesn't have a WHO_AM_I or DEVICE_ID register to check. Instead we read the W_CURRENT register that we're generally not using and therefore doesn't get changed. - The current is left at the default 17.5 mA but could be changed using the command line argument. Datasheet: https://www.ti.com/lit/ds/symlink/lp5562.pdf Signed-off-by: Julian Oes <julian@oes.ch>
67af398
to
f97b8c6
Compare
It looks like CI is the same as main, so I'll merge this now so I can backport it to v1.14 in time. Thanks for the reviews! |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-june-06-2023/32473/1 |
This adds support for the TI LP5562 RGB LED driver.
Things to note:
Datasheet:
https://www.ti.com/lit/ds/symlink/lp5562.pdf
Tested on the bench using a Pixhawk 6X.
This is required for some of the Holybro products switching to it.
FYI @vincentpoont2.
Needs backporting to v1.14.