-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modalai fcv2 board support for 1.14 #21653
Conversation
# Internal I2C mag | ||
bmm150 -I start | ||
# Don't start Internal I2C mag | ||
# bmm150 -I start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the internal mag dropped?
If nothing else it's useful having it to properly orient the external mag. The common modules from holybro and mro both use an ist8310, but it's mounted differently and we have no way to detect, so doing it at calibration time (relative to an internal) was the least bad option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to remember that it was giving us some grief but I don't remember exactly what that was so I'll ask around and see what the specific issue was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the flight test team just said that it was super noisy? Perhaps the idea is that you enable it but set SYS_HAS_MAG and MAG_TYPE parameters to not use it unless you have a secondary unit and then you just use the internal one for reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is internal mag used on Pixhawks in general? Just as a reference or as the actual primary source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how having the internal one enabled helps the calibration figure out the orientation. I just tried calibrating the external compass with and without the internal one enabled and in neither case did it determine the proper rotation of the external compass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our discussion I will leave this disabled for now
CONFIG_DRIVERS_UAVCAN=y | ||
CONFIG_BOARD_UAVCAN_INTERFACES=1 | ||
CONFIG_BOARD_UAVCAN_TIMER_OVERRIDE=2 | ||
# CONFIG_DRIVERS_UAVCAN=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to keep uavcan by default, there's actually a fair amount of usage and it's growing. I can suggest other modules to skip if flash is the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I need to remove some things so that it fits in flash. UAVCAN takes up a lot of room. But if you have other choices that are better I would love to hear them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added those back in and removed local position estimator and attitude estimator Q
…e estimator Q that are no longer supported.
* Removed obsolete voxl2-io directory * Updated support for ModalAI FC v2 board * Added UAVCAN back in and removed local position estimator and attitude estimator Q that are no longer supported. * Removed unneeded IMU drivers
Solved Problem
Board support for the ModalAI FC v2 had fallen out of date and needed to be updated. This includes the ModalAI systemcmd for running board diagnostics. Also, the obsolete voxl2-io directory has been removed. voxl2-io is no longer supported by ModalAI and has been replaced by a proprietary package.