-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.14 Backport] Geofence: Disable pre-emptive geofence predictor by default #21657
[1.14 Backport] Geofence: Disable pre-emptive geofence predictor by default #21657
Conversation
As discussed in https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372#v114-new-beta-release-5 This feature was not well tested / maintained, hence was agreed upon to be disabled for the 1.14 release
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a note in the param that this is an experimental feature?
Or what's the point of letting someone enabling it if we know that it can lead to a fly-away?
To discourage users from actually using it, and to understand the consequences
* [EXPERIMENTAL] Use Pre-emptive geofence triggering | ||
* | ||
* NOTE: This is an experimental feature and is known for causing flyaways on vehicles. Use at your own risk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-june-06-2023/32473/1 |
Should this also be disabled by default in main? |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Thanks for the reminder, it should! Hence I created a branch against the |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
About
As discussed in
https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372#v114-new-beta-release-5, Geofence predictor feature was not well tested / maintained, hence was agreed upon to be disabled for the 1.14 release
This is a backport because 1.14 has been branched out, but not going to
main
branch yet, since we haven't discussed what to do for the next release.