[1.14 Backport] Geofence: Disable pre-emptive geofence predictor by default #21657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372#v114-new-beta-release-5 This feature was not well tested / maintained, hence was agreed upon to be disabled for the 1.14 release
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372/1 |
bresch
reviewed
May 31, 2023
To discourage users from actually using it, and to understand the consequences
junwoo091400
commented
May 31, 2023
Comment on lines
131
to
133
| * [EXPERIMENTAL] Use Pre-emptive geofence triggering | ||
| * | ||
| * NOTE: This is an experimental feature and is known for causing flyaways on vehicles. Use at your own risk. |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
dagar
approved these changes
Jun 6, 2023
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-june-06-2023/32473/1 |
|
Should this also be disabled by default in main? |
junwoo091400
added a commit
to junwoo091400/PX4-Autopilot
that referenced
this pull request
Jul 23, 2023
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Thanks for the reminder, it should! Hence I created a branch against the |
dagar
pushed a commit
that referenced
this pull request
Jul 24, 2023
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
As discussed in
https://discuss.px4.io/t/px4-maintainers-call-may-30-2023/32372#v114-new-beta-release-5, Geofence predictor feature was not well tested / maintained, hence was agreed upon to be disabled for the 1.14 release
This is a backport because 1.14 has been branched out, but not going to
mainbranch yet, since we haven't discussed what to do for the next release.