delete unused ECL_LIB_GIT_VERSION #21677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneWayOut
force-pushed
the
DelEclGitVersion
branch
from
e664c12
to
2416685
Compare
Since 'ecl' is nomore a git submodule, code lines related to 'ECL_LIB_GIT_VERSION' could be deleted
oneWayOut
force-pushed
the
DelEclGitVersion
branch
from
2416685
to
70fe45a
Compare
dagar
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 'ecl' is nomore a git submodule, code lines related to 'ECL_LIB_GIT_VERSION' could be deleted
Solved Problem
I found that in src/lib/version/px_update_git_header.py (line 123) :
where 'ecl' used to be a submodule but now does not exist anymore, and the macro definition 'ECL_LIB_GIT_VERSION' is not referenced by any code, so it could be deleted.
Solution
Test coverage