ArmingChecks: disallow arming via parameter #21742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COM_ARMABLE is set to "Disabled" will prevent arming. This allows to set the parameter when ground demoing a drone or if it's in maintenance for safety reasons.
tstastny
approved these changes
Jun 20, 2023
|
Fun, we just enabled DEMO mode 🎉 |
|
We should do this lower level so that it can't be overridden by force arming (eg commander arm -f or command with magic value). |
Why would we do it differently than other checks? Force arming is not normally done or am I wrong? We should keep that one purely for the developer.
Is this necessary to keep? Don't we need a consistent way to enable/disable all checks and then it's obsolete? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The carrier is maintaining or showcasing the vehicle powered but not armed and wants to make sure it's not accidentally armed.
Solution
COM_ARMABLEdefaulting to allow arming which can be set to false to disallow armingChangelog Entry
For release notes:
Documentation: Parameter reference is automatically updated. Safety chapter does not specifically exist or does it?
Test coverage
Context