Navigator: loiter: remove unnecessary _loiter_pos_set #21776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
While working on #21775 I noticed this seemingly unnecessary class variable
_loiter_pos_set
, that was set to false inon_inactive()
or inon_active
, and then though only ever checked inon_activation
(throughset_loiter_position()
). I don't see how it could be false when entering on_activation(), and thus can just be removed, or am I missing something?Solution
Remove it!
Changelog Entry
For release notes:
Test coverage
Bit of SITL testing.