Handle illogical LOG_REQUEST_LIST messages more gracefully #21784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrisonmg
changed the title
bkueng
approved these changes
Jul 3, 2023
antbre
pushed a commit
to BioMorphic-Intelligence-Lab/PX4-Autopilot
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When you send a LOG_REQUEST_LIST message with the
startlog id > theendlog id, PX4 responds with LOG_ENTRY messages for every single log ID up until, I assume,_next_entryoverflows and finally== _last_entryat some point.Solution
This change results in just a single LOG_ENTRY being sent for the
startlog id ifend > start. I think this is a little better than sending up to u32 max value LOG_ENTRY messages.Test coverage
I really only tested this manually, but happy to perform other testing if necessary.