Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKF2 cleanup. Use MAX_NUM_x constants instead of hard-coded numbers #21809

Merged
merged 1 commit into from
Jul 6, 2023
Merged

EKF2 cleanup. Use MAX_NUM_x constants instead of hard-coded numbers #21809

merged 1 commit into from
Jul 6, 2023

Conversation

antonio-sc66
Copy link
Contributor

Solved Problem

I found that EKF2.cpp file used hard-coded values to check that the EKF2_MULTI_IMU and EKF2_MULTI_MAG values matched the maximum allowed value.

Solution

  • Use the already existing constants (defines) instead of hard-coded values. This defines were already available in EKF2.hpp

@antonio-sc66
EKF2 cleanup. Use MAX_NUM_x constants instead of hard-coded numbers
6295a14 
Signed-off-by: Antonio Sanjurjo C <74329840+antonio-sc66@users.noreply.github.com>
bresch
bresch approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bresch bresch merged commit c1cb48c into PX4:main Jul 6, 2023
81 of 84 checks passed
@antonio-sc66 antonio-sc66 deleted the feature-ekf2-check-max-instances-constants branch July 6, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bresch bresch bresch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonio-sc66 @bresch