-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KakutesH7/H7v2/H7mini: use EKF2 #21961
Conversation
param set-default ATT_W_ACC 0.4 | ||
param set-default ATT_W_GYRO_BIAS 0 | ||
|
||
# use EKF2 without mag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might also want to set EKF2_MAG_TYPE 5
(none)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do that for the other Kakutes either. So you're saying I should?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, in fact it's fine, the EKF will still initialize the heading using the yaw estimator if there is no mag data:
PX4-Autopilot/src/modules/ekf2/EKF/gps_control.cpp
Lines 126 to 141 in d4c7ea7
if (((_params.gnss_ctrl & GnssCtrl::HPOS) || (_params.gnss_ctrl & GnssCtrl::VEL)) | |
&& _control_status.flags.tilt_align | |
&& _NED_origin_initialised | |
) { | |
// if GPS is otherwise ready to go other than yaw align | |
if (!_control_status.flags.yaw_align && gps_checks_passing && !gps_checks_failing) { | |
if (resetYawToEKFGSF()) { | |
ECL_INFO("GPS yaw aligned using IMU"); | |
} | |
} | |
if (_control_status.flags.yaw_align) { | |
mandatory_conditions_passing = true; | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, ok, so I'll drop the commit again.
CONFIG_MODULES_BATTERY_STATUS=y | ||
CONFIG_MODULES_COMMANDER=y | ||
CONFIG_MODULES_CONTROL_ALLOCATOR=y | ||
CONFIG_MODULES_DATAMAN=y | ||
CONFIG_MODULES_EKF2=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you disable these ekf parts: https://github.com/PX4/PX4-Autopilot/blob/main/boards/px4/fmu-v2/default.px4board#L26-L31?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, even if a GPS might be connected potentially? And would you do it for all Kakutes or just the F7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPS will still work. We can do it for all of them as they're generally low on flash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, will do. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkueng it looks like there is no way to fit EKF2 onto 1MB flash on the KakuteF7. Any ideas what to do? Retire it, or going back to Q?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep Q then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's more we can carve up in EKF2.
Signed-off-by: Julian Oes <julian@oes.ch>
dc75045
to
9c83dda
Compare
To save flash. Signed-off-by: Julian Oes <julian@oes.ch>
9c83dda
to
d2dd52c
Compare
@julianoes @bresch Please merge. |
@vincentpoont2 did you test this? |
Yes, we did a test flight. The only thing we notice is the following warning. |
Thanks @vincentpoont2, then let's get this merged. |
https://logs.px4.io/plot_app?log=82c6495e-4196-4985-aa9d-8b8a9ebfe7c6 |
This switches Kakute F7 and H7v1 to EKF2 to match Kakute H7v2 and mini.
Untested, could you test @vincentpoont2 ?