Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT v1.4] Fix MAVLink forwarding #22310

Merged
merged 3 commits into from
Nov 9, 2023
Merged

[BACKPORT v1.4] Fix MAVLink forwarding #22310

merged 3 commits into from
Nov 9, 2023

Commits on Nov 5, 2023

  1. lib: add FIFO ringbuffer class 

    This adds a reusable class for a simple FIFO ringbuffer.

Signed-off-by: Julian Oes <julian@oes.ch>
    @julianoes
    julianoes committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    ad7032d View commit details
    Browse the repository at this point in the history

  2. lib: add variable length ringbuffer 

    This adds a reusable class for a FIFO ringbuffer that accepts variable
length packets. It is using the Ringbuffer class internally.

Signed-off-by: Julian Oes <julian@oes.ch>
    @julianoes
    julianoes committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    318d93e View commit details
    Browse the repository at this point in the history

  3. mavlink: fix MAVLink message forwarding 

    This switches from the horribly intertwined ringbuffer implementation to
the new VariableLengthRingbuffer implementation.

By ditching the previous implementation, we fix MAVLink message
forwarding, which didn't work reliably. The reason it didn't work is
that multiple mavlink messages could be added but only one of them was
sent out because the buffer didn't keep track of the messages properly
and only read the first one.

Signed-off-by: Julian Oes <julian@oes.ch>
    @julianoes
    julianoes committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    6520fea View commit details
    Browse the repository at this point in the history