[BACKPORT release/1.15] tools/bootloader: add force-erase option and add bootloader version #23210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davids5
reviewed
Jun 3, 2024
There was a problem hiding this comment.
@julianoes - I have the bugfix changes for the RT in #23110 (commits). Since this PR changes system behavior, I think we should bring in the bux fix PR first and then rebase this PR on it.
|
Ok, that's fine with me. Let me know when I should rebase it. |
@julianoes - Please rebase |
If the STM32H7 fails to program or erase a full chunk of 256 bytes, the ECC check will trigger a busfault when trying to read from it. To speed up erasing and optimize wear, we read before erasing to check if it actually needs erasing. That's when a busfault happens and the erase time outs. The workaround is to add an option to do a full erase without check. Credit goes to: ArduPilot/ardupilot#22090 And the protocol option added to the bootloader is the same as for ArduPilot, so compatible. Signed-off-by: Julian Oes <julian@oes.ch>
This adds a new protocol extension which allows to get the bootloader version. The bootloader version is different from the bootloader protocol revision which has stabilized at 5 and is not easy to update unless a bootloader is actually breaking the protocol. The reason being that both the Python script as well as the uploader used in QGC will not attempt to load firmware if they don't know the bootloader version, so it could basically be considered a "breaking" protocol revision. Signed-off-by: Julian Oes <julian@oes.ch>
Includes: - Remove some of the outdated Python2 checks and compatibility. - Try not catch all exceptions but only the expected ones. Otherwise, this makes it really hard to debug if anything unexpected actually goes wrong. - Make use of fstrings. - Make output slightly prettier. Signed-off-by: Julian Oes <julian@oes.ch>
Just so we don't conflict on these commands in the future.
Signed-off-by: Julian Oes <julian@oes.ch>
julianoes
force-pushed
the
pr-release/1.15-bootloader-backports
branch
from
ee43c0c
to
e5b40c1
Compare
Quite a few were missing, and everything on one line was hard to diff.
…P_RESERVATION_SIZE param (#23204)
julianoes
force-pushed
the
pr-release/1.15-bootloader-backports
branch
from
e5b40c1
to
5f76134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #22777
And fixups: #23174
And updated target list: #23234
Best to be rebased cleanly so that the git hash embedded in the bootloader makes sense and points to the actual branch.