-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move RTPS to dedicated px4fmu-v{3,4,4pro,5}, posix, sdflight builds #8113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dagar - This looks good. Is the CI failure real?
No, that's been failing intermittently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good
lib/micro-CDR | ||
) | ||
|
||
set(config_rtps_send_topics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the set of topics to common/rtps
? Will be easier to manage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds fine to me, but I don't think we know how this is actually intended to be used.
@@ -209,6 +213,14 @@ alt_firmware: \ | |||
check_s2740vc-v1_default \ | |||
sizes | |||
|
|||
# builds with RTPS | |||
check_rtps: \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to add this to CI? If so, we'll need to check the overhead of building all targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is for CI.
Looks good. I'd still like to be able to use the generated agent code without having to sync and build PX4 to get it. |
We could have Firmware output a library (with a cmake build system) that's automatically pushed to another github repo. That generated library could be versioned to match Firmware. |
Merging now to get it added to semaphoreci. I suspect this will go through a few more iterations once we figure out what to do with the generated agent code and the directory structure refactor. |
RTPS and micro-cdr now only included and required in the following builds