astyle allow version 3.1 #8689
Closed
astyle allow version 3.1 #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2018
|
I'm not sure if supporting multiple versions is realistic.
|
|
We can skip formatting checks on circleci temporarily until this is resolved. |
dagar
added a commit
that referenced
this pull request
Jan 15, 2018
- revert after #8689 is resolved
Merged
Merged
|
@LorenzMeier low priority, but we'll need to find a solution here. The current astyle installed via homebrew isn't currently working for PX4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circleci builds (OSX) are failing because astyle v3.1 is now being installed. Let's see if we can tolerate the additional version without code changes.