UBX GPS Reset #9910
Merged
UBX GPS Reset #9910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the Trimble MB-TWO and similar devices. Tested including GPX streams.
This is used by multi-antenna RTK systems.
LorenzMeier
force-pushed
the
pr-update-gps-reset
branch
from
dc05b27
to
8a1caff
Compare
LorenzMeier
commented
Jul 15, 2018
src/drivers/gps/gps.cpp
Outdated
| @@ -263,6 +263,7 @@ extern "C" __EXPORT int gps_main(int argc, char *argv[]); | |||
| GPS::GPS(const char *path, gps_driver_mode_t mode, GPSHelper::Interface interface, bool fake_gps, | |||
| bool enable_sat_info, Instance instance) : | |||
| _serial_fd(-1), | |||
| _baudrate(0), | |||
There was a problem hiding this comment.
@bkueng This was your scanning issue. The variable is used as state, but wasn't initialized properly.
There was a problem hiding this comment.
Well, I had additional local changes. The submodule update needed to be in sync with that.
…-off time for config reset.
|
This is good to go when it passes CI. |
|
There were a couple other uninitialized fields, so I moved to the class definition and did them all. |
dagar
approved these changes
Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resets UBX GPS units on boot to ensure that even configured units go back to factory defaults.