Catapult plugin for simulating catapult / handlaunching fixed wing #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
@Jaeyoung-Lim Why is CI failing? Can we fix that? |
|
@LorenzMeier I believe it is not only this PR but has been failing on Mac for quite some time now. I will have a look |
|
It is Mac OS. I looked for 30 minutes but could not find it yet (it works on my machine). |
|
Please rebase to re-run testing. |
Add catapult plugin template Fix Catapult plugin working Attach catapult plugin Cleanup print messages Cleanup
Jaeyoung-Lim
force-pushed
the
pr-fixedwing-catapult
branch
from
4ba732e
to
1b9bc8c
Compare
|
@LorenzMeier Thanks for the fix! All checks have passed 👍 |
|
@LorenzMeier @TSC21 @dagar If there is nothing missing, can we get this merged please? |
TSC21
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
This PR implements a catapult plugin, which simulates fixed wing being launched by a catapult or being hand launched. This is required to test the takeoff mode of the fixed wing, which has been largely untested in simulation until now.
Describe your solution
The plugin applies a fixed amount of force for a specified duration to simulate the launch.
Describe possible alternatives
This could have been implemented on a much aesthetically pleasing way, with a separate catapult mesh, but I think it is good enough for now to cover the tests that is needed for the firmware. It was very hard to find a good mesh of a catapult without licensing problems.
Test data / coverage
Additional context
This was brought up from a discussion with @dagar