Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Intel® RealSense™ Depth Camera D435i sensor module #44

Closed
wants to merge 13 commits into from

Conversation

serkanMzlm
Copy link

@serkanMzlm serkanMzlm commented Jun 5, 2024

  • The Intel® RealSense™ Depth Camera D435i module has been added. This allows for applications such as VIO (Visual Inertial Odometry) to be implemented.
    image

  • Added foggy and mountainous world model ( This model has been removed from the PX4-gazebo-models repository. You can access the part where the model is located through this link)

Screenshot from 2024-06-05 16-05-50

Copy link

@xdwgood xdwgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!!!

@@ -0,0 +1,268 @@
<?xml version="1.0" encoding="UTF-8"?>
<sdf version="1.9">
<world name="default">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<world name="mountain_fog">

<collision name="collision">
<geometry>
<heightmap>
<uri>file://media/dem/data.dem</uri>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not find data.dem file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, I missed that. That part was left while working on data.dem, it should be data.dt2. I corrected the error, but making complex shapes collisions no longer seems logical. Instead, simpler collisions can be used

@xdwgood
Copy link

xdwgood commented Jun 7, 2024

Screenshot from 2024-06-07 09-15-24

Do you know why point cloud data can't be displayed on gz?

@serkanMzlm
Copy link
Author

serkanMzlm commented Jun 7, 2024

Screenshot from 2024-06-07 09-15-24

Do you know why point cloud data can't be displayed on gz?

The point cloud data is not sufficient for visualization in this part. Additionally, you need to calculate and publish the gz::msgs::Float_V data

You can check out this plugin as an example

@serkanMzlm
Copy link
Author

serkanMzlm commented Jun 11, 2024

The Intel® RealSense™ Depth Camera D435i model works correctly with the PX4 software

Copy link

@xdwgood xdwgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working normally now.

@hamishwillee
Copy link

Note, when this goes in please update the docs. For Gazebo (gz) you can:

The main thing to capture though is, if I am a user, how can I actually use this? I.e. if this is used for VIO, what setup is needed? This might imply other docs need to be updated.

@serkanMzlm
Copy link
Author

@hamishwillee, VIO setups can be a bit challenging. You will need to download OpenVINS. Additionally, the camera needs to be calibrated in the simulation environment. Explaining and describing these processes can be quite time-consuming.

@hamishwillee
Copy link

VIO setups can be a bit challenging. You will need to download OpenVINS. Additionally, the camera needs to be calibrated in the simulation environment. Explaining and describing these processes can be quite time-consuming.

Thank you. To this I respond "the undocumented feature might as well not exist". But up to the you and the team to decide how much or how little it makes sense for this to be worth documenting (at all). I figure the absolute minimum is the world, because it is fun to try different environments and is independent of the sensor itself.

@serkanMzlm serkanMzlm closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants