Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AIRLink flight controller page #2140

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

aviaks
Copy link
Contributor

@aviaks aviaks commented Nov 12, 2022

AIRLink added to the list of supported flight controllers.


- **Easy to mount**

![Easy mount](../../assets/flight_controller/airlink/airlink-easy-to-mount.jpg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns image with bullet.

Suggested change
![Easy mount](../../assets/flight_controller/airlink/airlink-easy-to-mount.jpg)
![Easy mount](../../assets/flight_controller/airlink/airlink-easy-to-mount.jpg)


- **FPV camera comes as standard**

![FPV camera comes as standard](../../assets/flight_controller/airlink/airlink-fpv-camera.jpg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![FPV camera comes as standard](../../assets/flight_controller/airlink/airlink-fpv-camera.jpg)
![FPV camera comes as standard](../../assets/flight_controller/airlink/airlink-fpv-camera.jpg)

Comment on lines 993 to 994
- [Buy AIRLink 4G](https://sky-drones.com/sets/airlink-enterprise-set.html)
- [Buy AIRLink 5G](https://sky-drones.com/sets/airlink-5g-enterprise-set.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should these indicate edition? E.g. Airlink 4G Enterprise?
  • Should there be a purchase link for the "Core"?


## Peripherals

Peripherals information coming soon.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FMI, ETA on that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1-2 weeks or so. The idea is to add links to the peripherals added to the docs but peripheral pages have to be added first. So as soon as I add them and they're merged the links will be added in this section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great. No need to wait on it.

@hamishwillee
Copy link
Collaborator

@aviaks Looks great. Can you link the PRs where this went into PX4 and QGC?

I put some comments inline on the normal formatting rules. I can make some of these changes myself but I wanted you to be aware of what will happen.

Note, please also update en/SUMMARY.md to add this to the sidebar.

@aviaks
Copy link
Contributor Author

aviaks commented Nov 16, 2022

@hamishwillee Many thanks for reviewing and for the comments! Agree with all comments, committed, pushed and formatting rules noted for all future PRs.

PX4 Firmware PR Link: PX4/PX4-Autopilot#19529

en/SUMMARY.md updated as suggested.

@hamishwillee
Copy link
Collaborator

You're most welcome @aviaks - and thanks for making the markup changes. I made a few more - nothing to the meaning, cropped a few images, deleted the one that is no longer displayed, and fixed the position of the doc in the tree to match the order.

FYI, it is in no way mandatory, but some manufacturers also choose to provide an assembly guide like this: https://docs.px4.io/main/en/assembly/quick_start_cuav_pixhawk_v6x.html
That can make things even easier for users.

Merging now.

@hamishwillee hamishwillee merged commit 60d28ed into PX4:main Nov 17, 2022
@aviaks
Copy link
Contributor Author

aviaks commented Nov 17, 2022

@hamishwillee thank you very much!

Good point, we'll prepare and add assembly guide page.

Peripheral pages PRs coming soon.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants