-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jMAVSim: Added the option to run without the GUI #105
Conversation
Added a new command line argument to allow the user to run without the GUI. The new argument is -no-gui. This allows use of the simulator in environments that do not have a GUI, like a headless Docker.
Thanks for the PR @katzfey! I'll try this out and review it. |
@katzfey please rebase on top of master, then CI should pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct.
Unfortunately the problem is that the j3d libs still require a X11 DISPLAY variable as was also mentioned in #59 (comment).
I think the change is still worthwile but it doesn't allow it to be run in CI/docker just yet. |
Darn! Sorry about that. You would think that if I wanted it to run in a headless Docker that I would have tested it in a headless Docker. I'll keep working on it. |
What's the status on that? @katzfey does it run in docker now? I'll be happy to test it when it works for you! |
Well, I am testing in a Docker now and can reproduce the issue. I have made changes and it gets farther but still not quite there. |
when the gui has been disabled.
I have it all working now on headless docker. Need to clean up some commit comments and then I can submit a new PR. |
@JonasVautherin Please feel free to test the work now. It seems to be working for me on a headless system with the -no-gui option. Branch is run_without_gui in my repo https://github.com/katzfey/jMAVSim |
Which is this PR, right? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, it works for me in docker without $DISPLAY
.
I made two small comments that would be nice if you could check them.
2. Changed the gui parameter to showGui
Awesome, thanks @katzfey! |
Added a new command line argument to allow the user to run without the GUI. The
new argument is -no-gui. This allows use of the simulator in environments that
do not have a GUI, like a headless Docker.
Fixes #59.