-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated usage of pylab.find results in AttributeError in XMDYNPhotonMatterAnalysis #247
Comments
FWIW, in general the usage of
so it should be easy to remove it. |
The following seems to work, but I'm not sure it is conceptually equivalent to pylab.find:
|
This solution looks fine to me. It may be simplified as:
Could you @godot11 test if it works? @CFGrote What do you think? |
Tested but doesn't work as the arrays in the test are not Numpy arrays. |
@JunCEEE Seems I was wrong. The above fix made the code working by all means, but the results for some charges don't make too much sense. It seems pylab.find may not have been what I thought it was, a "numpyizer" wrapper around
(source), and was removed in matplotlib versions >= 3.1. |
I think to just put it here is enough: https://github.com/PaNOSC-ViNYL/SimEx/blob/master/Sources/python/SimEx/Analysis/XMDYNPhotonMatterAnalysis.py |
In
Analysis.XMDYNPhotonMatterAnalysis.XMDYNPhotonMatterAnalysis.load_snapshot()
, there is the following line:pylab.find
seems no longer availble in thepylab
namespace and this line results in anI couldn't find a reference to see when it was removed, but my environment corresponds to
environment.yml
.The text was updated successfully, but these errors were encountered: