Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more informations in setup from the __init__ file #74

Merged
merged 6 commits into from
Nov 4, 2022
Merged

more informations in setup from the __init__ file #74

merged 6 commits into from
Nov 4, 2022

Conversation

shervin86
Copy link
Contributor

No description provided.

JunCEEE
JunCEEE requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@JunCEEE JunCEEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple suggestion to make the version in download_url consistent.

setup.py Outdated Show resolved Hide resolved
@JunCEEE JunCEEE mentioned this pull request Oct 20, 2022
Closed
@shervin86
Copy link
Contributor Author

There was an issue with the unit tests because of changes in the pint and dill packages. I put an upper limit to their versions in the requirements. We should put a better solution to support more recent versions

@shervin86 shervin86 mentioned this pull request Nov 4, 2022
Merged
JunCEEE
JunCEEE approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@JunCEEE JunCEEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@JunCEEE
Copy link
Contributor

JunCEEE commented Nov 4, 2022

There was an issue with the unit tests because of changes in the pint and dill packages. I put an upper limit to their versions in the requirements. We should put a better solution to support more recent versions

I see. The dill problem has been reported in an early version: #46, I didn't expect it happened again. Let's just keep the version limit for this moment, and I will submit an issue to dill.

@JunCEEE JunCEEE merged commit 3da0f81 into master Nov 4, 2022
@JunCEEE JunCEEE deleted the setup branch November 4, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunCEEE JunCEEE JunCEEE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shervin86 @JunCEEE