New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: TASK: cache ModuleFileLoader::resolveTypeOfImport #13

Draft

mhsdesign wants to merge 1 commit into main from task/cacheModuleFileLoader

Contributor

mhsdesign commented Apr 9, 2023 •

edited

Loading

previously, every external type lookup will result in re-parsing

... but i guess it would better if we could cache ModuleNode::fromTokens

maybe by having a factory where we can cache by source like $moduleNodeFactory->createFromSource($source) -> then we can use this factory here ...


          Task: cache ModuleFileLoader::resolveTypeOfImport

26ae4df

previously, every external type lookup will result in re-parsing

mhsdesign changed the title ~~Task: cache ModuleFileLoader::resolveTypeOfImport~~ WIP: TASK: cache ModuleFileLoader::resolveTypeOfImport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment