Fix instructor embeddings #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the instructor embeddings code sample from Chapter 4 pp. 123 to use `sentence-transformers==3.3.0` and removes InstructorEmbedding (as published, the code snippet throws `ImportError: cannot import name 'cached_download' from 'huggingface_hub'`
|
Hello @intertwine, Thank you for contributing! I will accept your PR regarding the If the for loops ends, it shows that log and returns the custom crawler. Please remove the |
@iusztinpaul done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the instructor embeddings code sample from Chapter 4 pp. 123
sentence-transformers==3.3.0(as published, the code snippet throws
ImportError: cannot import name 'cached_download' from 'huggingface_hub')Also fixes an indentation error in the the
CrawlerDispatcherclass