fix: Adjustment items can be omitted when adjustment type is full #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgrayston-paddle
force-pushed
the
fix/adjustment-type-items
branch
from
922968c to
fc69012
Compare
| public readonly string $reason, | ||
| public readonly string $transactionId, | ||
| public readonly AdjustmentType|Undefined $type = new Undefined(), | ||
| ) { | ||
| if ($this->type === AdjustmentType::Partial() && ($this->items instanceof Undefined || empty($this->items))) { | ||
| $typeIsFull = AdjustmentType::Full()->equals($this->type); |
There was a problem hiding this comment.
$this->type === AdjustmentType::Partial() strict comparison can't be used here
| throw InvalidArgumentException::arrayIsEmpty('items'); | ||
| } | ||
|
|
||
| if ($typeIsFull && is_array($this->items)) { | ||
| throw new InvalidArgumentException('items are not allowed when the adjustment type is full'); |
There was a problem hiding this comment.
API returns error "Array must have at least 1 items" when an empty array is sent in request, and "items are not allowed when the adjustment type is full" when items are provided with full type
| } | ||
|
|
||
| public function jsonSerialize(): array | ||
| { | ||
| $items = []; | ||
| if (is_array($this->items)) { | ||
| $items = []; |
There was a problem hiding this comment.
Moved $items = [] inside is_array($this->items) check so that Undefined value is omitted from request
vifer
previously approved these changes
Dec 17, 2024
vifer
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed