This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Bitmain Sophon Saber Ops Implementation #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guangzhixie
changed the title
LittleMaer
reviewed
Jun 28, 2018
| @@ -37,17 +37,17 @@ namespace saber{ | |||
|
|
|||
| typedef TargetWrapper<BM, __device_target> BM_API; | |||
|
|
|||
| //TODO: check exception | |||
| //static bm_handle_t handle = get_bm_handle(); | |||
| // Init handle only once in the lifetime | |||
| static bm_handle_t handle; | |||
There was a problem hiding this comment.
线程安全嘛？还是说目前HW只支持single thread？
|
|
||
| #ifdef USE_BM |
There was a problem hiding this comment.
这样问题，要用模板特化。而不是在原始代码上加宏来控制。这样如果同时打开CMAKE里面的USE_CPU USE_BM可以保证执行正确嘛？
saber/funcs/activation.h
Outdated
| namespace anakin { | ||
| namespace saber { | ||
|
|
||
| #ifdef USE_BM |
There was a problem hiding this comment.
默认参数，可以在使用时显示传递。不要用宏来控制定义
LittleMaer
approved these changes
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.