Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HuaweiAscendNPU] Fix adaptive_max_pool2d #10140

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

shentanyue
Copy link
Collaborator

PR devices

NNadapter Ascend

PR types

Bug fixes

PR changes

OP

Description

修复 adaptive_max_pool2d 算子单测问题

@paddle-bot
Copy link

paddle-bot bot commented Mar 27, 2023

Thanks for your contribution!

@@ -154,7 +154,7 @@ void TestAdaptiveAveragePool2D(Place place, float abs_error = 2e-5) {
}

void TestAdaptiveMaxPool2D(Place place, float abs_error = 2e-5) {
for (auto dims : std::vector<std::vector<int64_t>>{{2, 3, 4, 5}}) {
for (auto dims : std::vector<std::vector<int64_t>>{{2, 3, 6, 6}}) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非对称单测用例会出现问题。

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shentanyue shentanyue merged commit 6f9b930 into PaddlePaddle:develop Mar 29, 2023
@shentanyue shentanyue deleted the fix_adaptive_pool branch March 29, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants