[PASS]fix conv_elementwise_tree_fuse_pass rm bug #6812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| @@ -146,9 +150,9 @@ void ConvElementwiseTreeFuser::InsertNewNode(SSAGraph* graph, | |||
| } | |||
|
|
|||
| // NOTE: Mark these node as intermediate at this place. | |||
| @@ -48,6 +60,7 @@ class ConvElementwiseTreeFuser : public FuseBase { | |||
| PMNode* conv_output_; | |||
There was a problem hiding this comment.
这三个PMNode*类型的成员变量可以去掉，改为临时变量。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【问题1】
在该 pass 中，需要限制 conv1x1 的输出 VarNode 只能有一个输出。当该 VarNode 有多个输出时，由于该 VarNode 被标记为了AsIntermediate，进而该 VarNode 被删除，导致该与该 VarNode 有连接关系的节点出现输入悬空状态，因此这时经 opt 转换输出的模型结构会出现问题。在 EfficientNetB0 模型上可以复现这个问题。
【解决方法】
对 conv1x1 的输出 VarNode 加上assert_only_one_output限制。
【效果】
可解决 EfficientNetB0 模型转换问题。
【问题2】
在对 HRNet_W18_C 模型进行 opt 转换时，图结果异常：有 5 个匹配 pattern，正常应该删除15个中间节点，但是删除了 39 个中间节点。
【解决方法】
该pass中将删除节点的操作从父类迁移到子类，删除节点操作不再依赖AsIntermediate()标记。
【效果】
可解决 HRNet_W18_C 模型转换问题。