Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NNAdapter][HuaweiAscendNPU] NNAdapter HAL compatible with multiple CANN versions and support Ascend 710 #7956

Merged
merged 11 commits into from
Dec 18, 2021
Merged

[NNAdapter][HuaweiAscendNPU] NNAdapter HAL compatible with multiple CANN versions and support Ascend 710 #7956

merged 11 commits into from
Dec 18, 2021

Conversation

shentanyue
Copy link
Collaborator

No description provided.

@paddle-bot-old
Copy link

Thanks for your contribution!

hong19860320
hong19860320 reviewed Dec 16, 2021
View reviewed changes
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/dependencies.cmake Outdated Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.h Outdated Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.cc Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.cc Outdated Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.cc Outdated Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.cc Outdated Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.cc Outdated Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.cc Outdated Show resolved Hide resolved
lite/backends/nnadapter/nnadapter/driver/huawei_ascend_npu/utility.cc Outdated Show resolved Hide resolved
hong19860320
hong19860320 approved these changes Dec 18, 2021
View reviewed changes
Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/ci_tools/ci_nn_accelerators_unit_test.sh
@@ -616,7 +618,7 @@ function huawei_ascend_npu_build_and_test() {
-DLITE_BUILD_EXTRA=ON \
-DLITE_WITH_NNADAPTER=ON \
-DNNADAPTER_WITH_HUAWEI_ASCEND_NPU=ON \
-DNNADAPTER_HUAWEI_ASCEND_NPU_SDK_ROOT="$sdk_root_dir" \
-DNNADAPTER_HUAWEI_ASCEND_NPU_SDK_ROOT="$NNADAPTER_HUAWEI_ASCEND_NPU_SDK_ROOT" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前面已经有了sdk_root_dir=$NNADAPTER_HUAWEI_ASCEND_NPU_SDK_ROOT
所以用$sdk_root_dir没问题，这个地方不必改，下次提 PR的时候恢复吧

@hong19860320 hong19860320 merged commit 80cc8fd into PaddlePaddle:develop Dec 18, 2021
@hong19860320 hong19860320 changed the title [NNAdapter] Support Ascend CANN compatible and support Ascend710 [NNAdapter][HuaweiAscendNPU] NNAdapter HAL compatible with multiple CANN versions and support Ascend 710 Dec 18, 2021
@shentanyue shentanyue deleted the support_ascend710 branch December 19, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhupengyang zhupengyang zhupengyang left review comments

@hong19860320 hong19860320 hong19860320 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shentanyue @hong19860320 @zhupengyang