-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pass] Add keepdims convert pass for OpenCL #8319
Merged
zhaoyang-star
merged 13 commits into
PaddlePaddle:develop
from
zhaoyang-star:keepdims_pass
Jan 27, 2022
Merged
[Pass] Add keepdims convert pass for OpenCL #8319
zhaoyang-star
merged 13 commits into
PaddlePaddle:develop
from
zhaoyang-star:keepdims_pass
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
zhaoyang-star
requested review from
daming5432,
xiaoxiaohehe001 and
sprouteer
January 21, 2022 06:27
daming5432
previously approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhenlin-work
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeepdimsConvertPass splits some ops whose attribute
keepdims
orkeep_dim
is false to two ops.The reason for adding this pass is that it is hard for gpu to do reshape opterations in arg_max/reduce_mean, etc,. So we split this problem.
原始模型部分截图:
应用本 Pass 后:
已在 text_intention_v1 模型中验证精度正确。