Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NNAdapter][Ascend] Support dynamic shape range #8585

Merged

Conversation

shentanyue
Copy link
Collaborator

No description provided.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 7, 2022

Thanks for your contribution!

ascend_config_params_.enable_dynamic_shape_range =
key_values[HUAWEI_ASCEND_NPU_ENABLE_DYNAMIC_SHAPE_RANGE];
} else {
ascend_config_params_.enable_dynamic_shape_range =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么不直接用GetBoolFromEnv?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为昇腾这边需要是字符串。如果用GetBoolFromEnv,后面又要从bool转为string的。

Copy link
Collaborator

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shentanyue shentanyue merged commit 6d06a0d into PaddlePaddle:develop Mar 14, 2022
@shentanyue shentanyue deleted the support_dynamic_shape_range branch March 14, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants