Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arm] optimize fp16 bilinear_interp for upsample #9447

Merged
merged 9 commits into from
Sep 16, 2022
Merged

[arm] optimize fp16 bilinear_interp for upsample #9447

merged 9 commits into from
Sep 16, 2022

Conversation

mjp9527
Copy link
Collaborator

@mjp9527 mjp9527 commented Sep 15, 2022

No description provided.

@@ -276,6 +280,39 @@ TEST(TesPoolGlobal, test_pool_fp16_global) {
}
#endif // global_pool

#if 1 // basic adaptive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来没有作用

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议删掉

@@ -88,6 +141,19 @@ void pooling_basic_fp16(POOLING_PARAM,
int pad_w = paddings[2];
int size_channel_in = win * hin;
int size_channel_out = wout * hout;

if (exclusive && adaptive && pad_h == 0 && pad_w == 0 && hin % hout == 0 &&
win % wout == 0 && pooling_type == "avg" && global_pooling == false) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_pooling == false --> !global_pooling

Copy link
Contributor

@liyancas liyancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjp9527 mjp9527 merged commit 7928acc into PaddlePaddle:develop Sep 16, 2022
@mjp9527 mjp9527 deleted the opt_interp branch November 28, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants