[HuaweiAscendNPU] Adjust the code to obtain Ascend CANN version #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shentanyue
requested review from
mjp9527,
zhupengyang and
hong19860320
as code owners
|
Thanks for your contribution! |
hong19860320
reviewed
Jan 3, 2023
| } | ||
| std::regex express( | ||
| "version=([0-9]+\\.[0-9]+\\.(RC)?[0-9]+\\.(alpha)?[0-9]*)"); | ||
| #if defined(LITE_WITH_ARM) |
There was a problem hiding this comment.
为了保证 NNAdapter的独立性，LITE_WITH_ARM 类似任何lite的宏都不能用在 NNAdapter 内部，可以参考 https://github.com/hong19860320/PaddleLite-generic-demo/blob/2f4ea88e1408953b45469589fe5b678c5f4843db/image_classification_demo/shell/demo.cc#L585
There was a problem hiding this comment.
关于 LITE_WITH_PYTHON 的宏定义也建议用 NNAdapter 本身的宏，例如 NNADAPTER_WITH_PYTHON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.