[ARM] add Linear_interp && Linear_interp_v2 op;fix scale_act_fuse_pass and conv_scale_fuse_pass #9983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and conv_scale_fuse_passå
|
Thanks for your contribution! |
lite/operators/interpolate_op.cc
Outdated
| } /* namespace operators */ | ||
| } /* namespace lite */ | ||
| } /* namespace paddle */ | ||
|
|
||
| REGISTER_LITE_OP(nearest_interp, paddle::lite::operators::InterpolateOp); | ||
| REGISTER_LITE_OP(bilinear_interp, paddle::lite::operators::InterpolateOp); | ||
| REGISTER_LITE_OP(linear_interp, paddle::lite::operators::InterpolateOp1D); |
There was a problem hiding this comment.
为什么需要单独定义一个 InterpolateOp1D，其处理能合并到 InterpolateOp 里面吗？如果不能，为啥不定义成 LinearInterpolateOp ，这样是否更清楚？同理，arm math 的 interpolate1D 存在一样的情况，命名方面，建议与实际算子名称对应，否则不太好理解。
There was a problem hiding this comment.
好的， InterpolateOp1D 之前是看paddle里linear是1D，nearest/bilinear是2D，这块我重新整理一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR devices
Arm
PR types
New features && Bug fixes
PR changes
OP && PASS && Kernels && Backends
Description
在Arm端新增Linear_interp/Linear_interp_v2 OP实现；
修复 scale_fuse_activation_pass 和 conv_fuse_scale_pass 对激活函数设置不正确的bug